Merge pull request 'Mergin dev - new header, updated servants' (#29) from dev into main

Reviewed-on: #29

.forgejo/workflows/build_preview.yml

@@ -1,7 +1,7 @@
 on:
   push:
     tags:
-      - '[0-9]+\.[0-9]+\.[0-9]+-pre\.[0-9]+'
+      - '[0-9]+\.[0-9]+\.[0-9]+pre[0-9]+'
 
 jobs:
   checking:

.forgejo/workflows/unlighthouse.yml

@@ -1,12 +1,13 @@
 on:
   push:
     tags:
-      - '[0-9]+\.[0-9]+\.[0-9]+-ulh\.[0-9]+'
+      - '[0-9]+\.[0-9]+\.[0-9]+unlighthouse[0-9]+'
+      - '[0-9]+\.[0-9]+\.[0-9]+ulh[0-9]+'
 
 jobs:
   unlighthouse:
     runs-on: docker
-    container: forgejo.neshweb.net/ci-docker-images/unlighthouse:0.2.1
+    container: forgejo.neshweb.net/ci-docker-images/unlighthouse:latest
     steps:
       - name: Checkout repository
         uses: https://code.forgejo.org/actions/checkout@v3 

Dockerfile

@@ -4,7 +4,7 @@ COPY . .
 RUN npm i
 RUN npm run build
 
-FROM forgejo.neshweb.net/ci-docker-images/website-serve:0.1.3 AS runtime
+FROM forgejo.neshweb.net/ci-docker-images/website-serve:latest AS runtime
 
 COPY --from=build /app/dist /public
 COPY --from=build /app/serve.json /public/serve.json

README.md

@@ -2,6 +2,43 @@
 
 This is build using [Astro](https://astro.build)
 
+
+## 🚀 Project Structure
+
+```
+/
+├── static/
+│   ├── favicon.svg
+│   └── other files ...
+│
+├── src/
+│   ├── components/
+│   │   ├── servantCard.astro
+│   │   ├── ceCard.astro
+│   │   ├── contactCard.astro
+│   │   └── taCard.astro
+│   │
+│   ├── layouts/
+│   │   ├── customFooter.astro
+│   │   ├── baseSection.astro
+│   │   ├── taSection.astro
+│   │   ├── contactSection.astro
+│   │   └── Layout.astro
+│   │
+│   └── pages/
+│       └── index.astro
+│
+├── .gitlab-ci.yml
+├── astro.config.mjs
+└── package.json
+```
+
+Astro looks for `.astro` or `.md` files in the `src/pages/` directory. Each page is exposed as a route based on its file name.
+
+More routes will follow soon
+
+Any static assets, like images, can be placed in the `static/` directory.
+
 ## 🧞 Astro-Specific Commands
 
 All commands are run from the root of the project, from a terminal:
@@ -14,3 +51,4 @@ All commands are run from the root of the project, from a terminal:
 | `npm run preview`      | Preview your build locally, before deploying       |
 | `npm run astro ...`    | Run CLI commands like `astro add`, `astro preview` |
 | `npm run astro --help` | Get help using the Astro CLI                       |
+

package-lock.json

@@ -1,12 +1,12 @@
 {
 	"name": "@firq/fgosite",
-	"version": "0.1.28-pre.4",
+	"version": "0.1.27",
 	"lockfileVersion": 2,
 	"requires": true,
 	"packages": {
 		"": {
 			"name": "@firq/fgosite",
-			"version": "0.1.28-pre.4",
+			"version": "0.1.27",
 			"dependencies": {
 				"@astro-community/astro-embed-youtube": "^0.4.3",
 				"@astrojs/check": "^0.3.3",
@@ -2787,9 +2787,9 @@
 			}
 		},
 		"node_modules/caniuse-lite": {
-			"version": "1.0.30001636",
+			"version": "1.0.30001634",
-			"resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001636.tgz",
+			"resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001634.tgz",
-			"integrity": "sha512-bMg2vmr8XBsbL6Lr0UHXy/21m84FTxDLWn2FSqMd5PrlbMxwJlQnC2YWYxVgp66PZE+BBNF2jYQUBKCo1FDeZg==",
+			"integrity": "sha512-fbBYXQ9q3+yp1q1gBk86tOFs4pyn/yxFm5ZNP18OXJDfA3txImOY9PhfxVggZ4vRHDqoU8NrKU81eN0OtzOgRA==",
 			"funding": [
 				{
 					"type": "opencollective",
@@ -10847,9 +10847,9 @@
 			"integrity": "sha512-xlx1yCK2Oc1APsPXDL2LdlNP6+uu8OCDdhOBSVT279M/S+y75O30C2VuD8T2ogdePBBl7PfPF4504tnLgX3zfw=="
 		},
 		"caniuse-lite": {
-			"version": "1.0.30001636",
+			"version": "1.0.30001634",
-			"resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001636.tgz",
+			"resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001634.tgz",
-			"integrity": "sha512-bMg2vmr8XBsbL6Lr0UHXy/21m84FTxDLWn2FSqMd5PrlbMxwJlQnC2YWYxVgp66PZE+BBNF2jYQUBKCo1FDeZg=="
+			"integrity": "sha512-fbBYXQ9q3+yp1q1gBk86tOFs4pyn/yxFm5ZNP18OXJDfA3txImOY9PhfxVggZ4vRHDqoU8NrKU81eN0OtzOgRA=="
 		},
 		"ccount": {
 			"version": "2.0.1",

package.json

@@ -1,7 +1,7 @@
 {
 	"name": "@firq/fgosite",
 	"type": "module",
-	"version": "0.1.28-pre.4",
+	"version": "0.1.27",
 	"private": true,
 	"scripts": {
 		"dev": "astro dev",

src/components/navbar.astro

@@ -6,14 +6,14 @@ const hamburger_src_url = `url("${hamburger.src}")`;
 ---
 
 <header>
-  <a href="/" rel="noopener noreferrer" aria-label="Home" role="link">
+  <a href="/" rel="noopener noreferrer" aria-label="Home" role="navigation">
-    <Image src={logo} alt=""/>
+    <Image src={logo} alt="Firq Website Logo"/>
-    <span class="visually-hidden">Firq Logo</span>
+    <span class="visually-hidden">Firq Website Logo</span>
   </a>
   <ul class="desktop">
     <slot name="desktop"/>
   </ul>
-  <button class="mobile" aria-label="Navigation Button" tabindex="0" onclick="this.focus()" role="button">
+  <button class="mobile" aria-label="Navigation Button" tabindex="0" onclick="this.focus()" role="navigation">
     <ul>
       <slot name="mobile"/>
     </ul>

src/pages/blog/deploying-this-round-2.md

@@ -89,7 +89,7 @@ The container is also published to the docker registry that the Forgejo instance
 
 Since my website is now using a docker container instead of the previous `rsync` + `screen` approach, a new deployment solution was needed.
 
-In the end, Neshura proposed to use <a href="https://github.com/louislam/dockge" target="_blank" rel="noopener noreferrer" >Dockge</a>, a new, simple container management tool build by the developer of the beloved uptime-kuma. With that set up, getting the website only was really really easy:
+In the end, Neshura proposed to use <a href="https://github.com/louislam/dockge" target="_blank" rel="noopener noreferrer" style="font-style: unset">Dockge</a>, a new, simple container management tool build by the developer of the beloved uptime-kuma. With that set up, getting the website only was really really easy:
 
 1. Create a new stack
 2. Add a container entry
@@ -161,4 +161,4 @@ In the end, I must say migrating was a lot more painless than expected. Sure, Fo
 
 I also updated my about page to now reflect the migration, as the old technologies weren't up-to-date anymore.
 
-If you want to check out the repository by yourself, feel free to do so. <a href="https://forgejo.neshweb.net/Firq/firq-dev-website" target="_blank" rel="noopener noreferrer" >It is available on Neshuras Forgejo instance</a>
+If you want to check out the repository by yourself, feel free to do so. <a href="https://forgejo.neshweb.net/Firq/firq-dev-website" target="_blank" rel="noopener noreferrer" style="font-style: unset">It is available on Neshuras Forgejo instance</a>

src/pages/blog/instant-death.mdx

@@ -18,10 +18,10 @@ it doesn't interact with the hitrate, but if you have proof that this is differe
 
 Instant Kill & Instant Death: One of the most rejected systems to exist in FGO. Most players know of it, but discard it because of its unreliability and uselessness against stronger enemies. In this article, I want to dive a bit into the workings of Instant Kill and help you understand how you can, in specific scenarios, use it to your advantage.
 
-There are a multitude of servants that have access to instant-kill, but I will only highlight a few here (You can view the full list on <a href="https://gamepress.gg/grandorder/instant-death" target="_blank" rel="noopener noreferrer" >Gamepress</a>)
+There are a multitude of servants that have access to instant-kill, but I will only highlight a few here (You can view the full list on <a href="https://gamepress.gg/grandorder/instant-death" target="_blank" rel="noopener noreferrer" style="font-style: unset">Gamepress</a>)
 
 - **Nitocris (Caster)**: The most prominent figure, as she has easy access to her instant-killing NP and a skill that increases her death hit rate
-- **Void Shiki (Saber)**: Another Example of an AOE Instant-Kill servant who also has access to Death Resist debuffs. One quest in her release event even specifically used the Instant Kill mechanic (<a href="https://apps.atlasacademy.io/db/NA/quest/94021308/1" target="_blank" rel="noopener noreferrer" >Quest Link here</a>)
+- **Void Shiki (Saber)**: Another Example of an AOE Instant-Kill servant who also has access to Death Resist debuffs. One quest in her release event even specifically used the Instant Kill mechanic (<a href="https://apps.atlasacademy.io/db/NA/quest/94021308/1" target="_blank" rel="noopener noreferrer" style="font-style: unset">Quest Link here</a>)
 - **King Hassan (Assassin)**: The only servant that can afflict enemies with instant death on normal attacks (Note: David can do this as well, but only if he has his Bond CE equipped)
 
 But since Instant Kill is based on probability, most players are relucatant to use it in their farming compositions. This thems from the different death rates enemies have:
@@ -53,10 +53,10 @@ The parameters here are the following:
 
 ## Example
 
-The main reason this came up was because of a farming comp used in <a href="https://apps.atlasacademy.io/db/NA/quest/94061820/1" target="_blank" rel="noopener noreferrer" >Hunting Quest XI - Day 5 - Pride+</a>. The node is structured
+The main reason this came up was because of a farming comp used in <a href="https://apps.atlasacademy.io/db/NA/quest/94061820/1" target="_blank" rel="noopener noreferrer" style="font-style: unset">Hunting Quest XI - Day 5 - Pride+</a>. The node is structured
 into a 2 - 1 - 1 Layout, meaning using a dual-DPS setup would be the way to go.
 
-Looking at the stats for the first wave, it made sense to use Nitocris: Both Ghouls have a 100% Death Rate <a href="https://apps.atlasacademy.io/db/NA/enemy/9940700" target="_blank" rel="noopener noreferrer" >according to Atlas Academy</a>.
+Looking at the stats for the first wave, it made sense to use Nitocris: Both Ghouls have a 100% Death Rate <a href="https://apps.atlasacademy.io/db/NA/enemy/9940700" target="_blank" rel="noopener noreferrer" style="font-style: unset">according to Atlas Academy</a>.
 
 I went with using Nitocris, since she has a 100% NP charge and a skill that increases her Instant Death rate by 100%. Not needing any additional charge meant that no other buffs or AOE charges needed to be used on turn 1.
 

static/data/_servantdata.json

@@ -190,7 +190,7 @@
 		"bond10": false
 	},
 	{
-		"name": "Taigong Wang",
+		"name": "Taigon Wang",
 		"level": "70",
 		"np": "1",
 		"skills": "10 / 9 / 10",