Various bugfixes and changes
1: Script had AAAA hardcoded, this would've changed all records to AAAA. 2: Script was not saving the DNS Records ids, only their names this would've made it impossible to actually edit the DNS Record 3: Lowered the amount of printing going on, removed irrelevant information such as zoneid from the print statements, also removed most printing during the update phase
This commit is contained in:
parent
26fcc3859f
commit
27bb82767b
1 changed files with 19 additions and 18 deletions
|
@ -46,15 +46,19 @@ class DNSUpdater:
|
|||
print(f"Zone ID: {zone['id']} | Zone Name: {zone['name']}")
|
||||
|
||||
def get_dns_records(self, log=False):
|
||||
dns_records = self._cloudflare.zones.dns_records.get(self.zone_id)
|
||||
dns_records_all = self._cloudflare.zones.dns_records.get(self.zone_id)
|
||||
|
||||
dns_names = {'A' : [], 'AAAA' : []}
|
||||
for dnsrecord in dns_records:
|
||||
if log:
|
||||
print(f"DNS Name: {dnsrecord['name']} | ID: {dnsrecord['id']} | Type : {dnsrecord['type']} | IP: {dnsrecord['content']}")
|
||||
dns_names[dnsrecord['type']].append(dnsrecord["name"])
|
||||
dns_records_to_update = {'A' : [], 'AAAA' : []}
|
||||
for dnsrecord in dns_records_all:
|
||||
if dnsrecord['type'] in ['A', 'AAAA']:
|
||||
if log:
|
||||
print(f"DNS Name: {dnsrecord['name']} | Type : {dnsrecord['type']} | IP: {dnsrecord['content']}")
|
||||
dns_records_to_update[dnsrecord['type']].append(dnsrecord)
|
||||
else:
|
||||
if log:
|
||||
print(f"| Unknow DNS | Type: {dnsrecord['type']} | Zone: {dnsrecord['name']}")
|
||||
|
||||
self.DNSNAMES = copy.deepcopy(dns_names)
|
||||
self.DNSRECORDS = copy.deepcopy(dns_records_to_update)
|
||||
|
||||
def update_records(self):
|
||||
if self.IPVER == 'skip':
|
||||
|
@ -76,18 +80,15 @@ class DNSUpdater:
|
|||
print(names_replace)
|
||||
for name in names_replace:
|
||||
fullname = f"{name}.{self.HOSTNAME}"
|
||||
print(fullname)
|
||||
|
||||
for x in self.DNSNAMES:
|
||||
if x['name'] == fullname:
|
||||
dns_record_id = x['id']
|
||||
print(dns_record_id)
|
||||
|
||||
if fullname in self.DNSNAMES[dnstype]:
|
||||
new_dnsrecord = {"name": fullname, "type": "AAAA", "content": self.IPNEW}
|
||||
print(f"Sending request {new_dnsrecord}")
|
||||
r = self._cloudflare.zones.dns_records.patch(self.zone_id, dns_record_id, data=new_dnsrecord)
|
||||
print(r)
|
||||
for record in self.DNSRECORDS[dnstype]:
|
||||
if record['name'] == fullname:
|
||||
new_dnsrecord = {"name": fullname, "type": dnstype, "content": self.IPNEW}
|
||||
print(f"Sending request {new_dnsrecord}")
|
||||
res = self._cloudflare.zones.dns_records.patch(self.zone_id, record['id'], data=new_dnsrecord)
|
||||
if res['content'] != new_dnsrecord['content']:
|
||||
print(res)
|
||||
|
||||
|
||||
|
||||
if __name__ == '__main__':
|
||||
|
|
Loading…
Reference in a new issue