Neshura/cloudflare-dns-updater
Neshura/cloudflare-dns-updater
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases 39 Packages 2 Activity Actions

Investigate Crash on Router restart #17

New issue
Closed
opened 2023-03-18 16:06:05 +00:00 by Firq · 5 comments
Firq commented 2023-03-18 16:06:05 +00:00 (Migrated from gitlab.neshweb.net)
Copy link

Problem:

Since the DSL provider seemed to lose power and no requests were possible, it seems like the resulting timeouts were the source of the crash.
Feel free to investigate further

Proposed solution:

Implement error-handling if the responses time out

**Problem:** Since the DSL provider seemed to lose power and no requests were possible, it seems like the resulting timeouts were the source of the crash. Feel free to investigate further **Proposed solution:** Implement error-handling if the responses time out
Firq commented 2023-03-18 16:06:06 +00:00 (Migrated from gitlab.neshweb.net)
Copy link

assigned to @Neshura

assigned to @Neshura
Neshura commented 2023-03-18 16:09:03 +00:00 (Migrated from gitlab.neshweb.net)
Copy link

Issue is unrelated to Router restarts, also occasionally occurs without them. Cause is an expected field on the HTTP Request that is not present.

Fix should be easy (check HTTP Status code before parsing) but I'm lazy.

Issue is unrelated to Router restarts, also occasionally occurs without them. Cause is an expected field on the HTTP Request that is not present. Fix should be easy (check HTTP Status code before parsing) but I'm lazy.
Neshura commented 2023-03-21 09:41:45 +00:00 (Migrated from gitlab.neshweb.net)
Copy link

mentioned in commit 2287e8da9d

mentioned in commit 2287e8da9d9668042d5fc429899156bb8fb1a905
Neshura commented 2023-03-27 09:12:13 +00:00 (Migrated from gitlab.neshweb.net)
Copy link

Issue seems to be fixed, closing for now.

Issue seems to be fixed, closing for now.
Firq commented 2023-03-27 09:48:59 +00:00 (Migrated from gitlab.neshweb.net)
Copy link

image

![image](/uploads/2dd29f2460098c34f037c9cf8c795a6d/image.png)
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1.1.10
1.1.9
1.1.8
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.2-rc.3
1.1.2-rc.2
1.1.2-rc.1
1.1.1
1.1.1-rc.7
1.1.1-rc.6
1.1.1-rc.5
1.1.1-rc.4
1.1.1-rc.3
1.1.1-rc.2
1.1.1-rc.1
1.1.0
1.1.0-rc.1
1.0.0
1.0.0-rc.3
1.0.0-rc.2
1.0.0-rc.1
0.2.12
0.2.11
0.2.10
0.2.9
0.2.8
0.2.7
0.2.6
0.2.5
0.2.4
0.2.3
0.2.2
0.2.1
0.2
Labels
Clear labels   
bug

Something is not working as intended

  
bugfix

Anything related to fixing a bug

  
improvement

Improvement of any kind, could also be documentation

  
rewrite

Non-functional changes to the code

No labels
bug
bugfix
improvement
rewrite
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Neshura/cloudflare-dns-updater#17
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?