Neshura/cloudflare-dns-updater
Neshura/cloudflare-dns-updater
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases 38 Packages Activity Actions

Hotfix for #2 : Errors when type is TXT #20

Merged
Firq merged 0 commits from hotfix/TXT into main 2022-11-27 17:52:19 +00:00
Conversation 13 Commits - Files changed -
Firq commented 2022-11-27 17:09:49 +00:00 (Migrated from gitlab.neshweb.net)
Copy link

Added errorhandling to prevent #2 from happening.

The code will now print out any dns record that doesn't match the type of A or AAAA. This will be investigated further

Also updated from PUT to PATCH because the request only changes necessary fields (needs practice testing, can be reverted)

Added errorhandling to prevent #2 from happening. The code will now print out any dns record that doesn't match the `type` of `A` or `AAAA`. This will be investigated further Also updated from `PUT` to `PATCH` because the request only changes necessary fields (needs practice testing, can be reverted)
Firq commented 2022-11-27 17:09:50 +00:00 (Migrated from gitlab.neshweb.net)
Copy link

requested review from @Neshura

requested review from @Neshura
Firq commented 2022-11-27 17:09:50 +00:00 (Migrated from gitlab.neshweb.net)
Copy link

assigned to @Firq

assigned to @Firq
Neshura commented 2022-11-27 17:35:41 +00:00 (Migrated from gitlab.neshweb.net)
Copy link

added 1 commit

  • b8c74f2a - Fix due to bad push on branch feature/dockerize

Compare with previous version

added 1 commit <ul><li>b8c74f2a - Fix due to bad push on branch feature/dockerize</li></ul> [Compare with previous version](/Neshura/cloudflare-dns-updater/-/merge_requests/2/diffs?diff_id=36&start_sha=6a059e680692102f782ee3a84b6174068a843929)
Neshura commented 2022-11-27 17:36:34 +00:00 (Migrated from gitlab.neshweb.net)
Copy link

added 1 commit

  • 66a85c32 - Fix due to bad push on branch feature/dockerize

Compare with previous version

added 1 commit <ul><li>66a85c32 - Fix due to bad push on branch feature/dockerize</li></ul> [Compare with previous version](/Neshura/cloudflare-dns-updater/-/merge_requests/2/diffs?diff_id=37&start_sha=b8c74f2a354d9191c1ba3a9f1911fa01dd05fdf5)
Neshura commented 2022-11-27 17:39:38 +00:00 (Migrated from gitlab.neshweb.net)
Copy link

added 1 commit

  • aaa3da5c - Added ipv4 specification to bash script

Compare with previous version

added 1 commit <ul><li>aaa3da5c - Added ipv4 specification to bash script</li></ul> [Compare with previous version](/Neshura/cloudflare-dns-updater/-/merge_requests/2/diffs?diff_id=39&start_sha=66a85c320df86ae039dbb14782676b6484258d06)
Neshura commented 2022-11-27 17:42:53 +00:00 (Migrated from gitlab.neshweb.net)
Copy link

added 1 commit

  • 536a9cea - Revert change from put to patch for now

Compare with previous version

added 1 commit <ul><li>536a9cea - Revert change from put to patch for now</li></ul> [Compare with previous version](/Neshura/cloudflare-dns-updater/-/merge_requests/2/diffs?diff_id=41&start_sha=aaa3da5cbb06ccf08b0202fa6e308414abb10ce3)
Neshura commented 2022-11-27 17:43:37 +00:00 (Migrated from gitlab.neshweb.net)
Copy link

added 1 commit

  • 56e14400 - Revert "Revert change from put to patch for now"

Compare with previous version

added 1 commit <ul><li>56e14400 - Revert &quot;Revert change from put to patch for now&quot;</li></ul> [Compare with previous version](/Neshura/cloudflare-dns-updater/-/merge_requests/2/diffs?diff_id=43&start_sha=536a9ceaa14cd06e32bbe505b2eec49af537f317)
Neshura commented 2022-11-27 17:49:09 +00:00 (Migrated from gitlab.neshweb.net)
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>61f952f0 - Added venv to gitignore</li><li>439716ed - Try Catch around the ip put</li></ul> [Compare with previous version](/Neshura/cloudflare-dns-updater/-/merge_requests/2/diffs?diff_id=45&start_sha=56e144005b6b9569fd7d168dfda06bc3f811661c)
Neshura commented 2022-11-27 17:50:10 +00:00 (Migrated from gitlab.neshweb.net)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>2b0dae76 - Uncaught syntax error</li></ul> [Compare with previous version](/Neshura/cloudflare-dns-updater/-/merge_requests/2/diffs?diff_id=46&start_sha=439716ed67756547999862e641632e89751e1ddf)
Neshura commented 2022-11-27 17:51:42 +00:00 (Migrated from gitlab.neshweb.net)
Copy link

Had to make some changes to fix errors made by myself in earlier commits and unexpected errors in the python script

Had to make some changes to fix errors made by myself in earlier commits and unexpected errors in the python script
Neshura commented 2022-11-27 17:51:48 +00:00 (Migrated from gitlab.neshweb.net)
Copy link

approved this merge request

approved this merge request
Neshura commented 2022-11-27 17:52:19 +00:00 (Migrated from gitlab.neshweb.net)
Copy link

mentioned in commit fd19efd007

mentioned in commit fd19efd007e8c3803012cf7eec50c4c3c4d1e0b6
Neshura commented 2022-11-27 18:22:15 +00:00 (Migrated from gitlab.neshweb.net)
Copy link

mentioned in issue #2

mentioned in issue #2
Neshura (Migrated from gitlab.neshweb.net) approved these changes 2023-12-10 00:57:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Neshura
Labels
Clear labels   
bug

Something is not working as intended

  
bugfix

Anything related to fixing a bug

  
improvement

Improvement of any kind, could also be documentation

  
rewrite

Non-functional changes to the code

No labels
bug
bugfix
improvement
rewrite
Milestone
Clear milestone
No items
No milestone
0.1
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Neshura/cloudflare-dns-updater#20
No description provided.
Delete branch "hotfix/TXT"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?